Testing/Build Workflows #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
smokestacklightnin
requested changes
May 30, 2025
|
TODO: move test dependencies hardcoded in test.yml to extras-require as discussed here |
* Add build workflow via docker * rename docker-compose to docker compose * add twine check and upload to PyPi * add workflow_dispatch * install twine before twine check
1. To ensure test compatibility between NumPy v1 and v2 environments, we've adjusted the comparison tolerance to 1e-4. This accommodates slight variations (around 1e-4) in floating-point outcomes between the two NumPy versions. Additionally, we've modified the expected proto float to align with NumPy v2 results. 2. For mutual_information, NumPy v2 is able to handle values > 2**53 if the min and max of the examples are the same. However, since we need to be compatible with NumPy v1 and v2, for related unit tests, we check for the NumPy version before running the associated unit tests. PiperOrigin-RevId: 681598675
andrewfulton9
force-pushed
the
testing-workflow
branch
from
9cb79b3 to
969cad0
Compare
.github/reusable-build/action.yml
Outdated
| name: data-validation-wheel-py${{ matrix.python-version }} | ||
| path: dist/*.whl | ||
|
|
||
| - name: Install built wheel |
There was a problem hiding this comment.
Should this be installing the wheel in the runner?
There was a problem hiding this comment.
Just updated the name. Good catch!
peytondmurray
requested changes
Jun 12, 2025
There was a problem hiding this comment.
A few things:
- Change the
reusable-buildaction to not sayInstall built wheel, since we're not doing that - Update the places where
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")is to either remove the mention of the PR, or point to the correct PR (266) - Can you make an issue to remove all the calls to
absltest.mainsince we're no longer using absl to run tests?
1 and 2 have been addressed, and I opened #271 to address 3 |
|
Merging; with the current dependency on zetasql, this build will time out. We'll be introducing a PR to remove the zetasql dependency later on, at which point these workflows will become relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copybara overwrote these previously merged commits. This PR adds them back in. Note that currently the build fails due to some dependency versions only being available via nightly builds